linux-kernel - Re: [PATCH] renesas; Silence uninitialized variable report in usbhsg_recip_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120124081116.GF27414@legolas.emea.dhcp.ti.com>
Date:	Tue, 24 Jan 2012 10:11:19 +0200
From:	Felipe Balbi <balbi@...com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Subject: Re: [PATCH] renesas; Silence uninitialized variable report in
 usbhsg_recip_run_handle()

On Mon, Jan 16, 2012 at 10:42:10PM +0100, Jesper Juhl wrote:
> In drivers/usb/renesas_usbhs/mod_gadget.c::usbhsg_recip_run_handle()
> the Coverity Prevent checker currently flags a warning about possibly
> uninitialized use of 'ret' i usbhsg_recip_run_handle(). It does this
> since it assumes we take one of the non-default branches in the switch
> and then subsequently take the false branch in the 'if (func)' case
> below. This exact scenario will never happen, but Coverity can't see
> that for some reason. This patch initializes 'ret' to '0' when it is
> declared which should shut up this report and won't really hurt - so
> why not? At least then it's clear that 'ret' is always initialized..
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

applied, thanks

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)