linux-kernel - Re: [PATCH stable 3/4] block: fail SCSI passthrough ioctls on partition devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Jan 2012 13:56:10 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	stable@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Petr Matousek <pmatouse@...hat.com>,
	linux-scsi@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	James Bottomley <JBottomley@...allels.com>
Subject: Re: [PATCH stable 3/4] block: fail SCSI passthrough ioctls on partition
 devices

On 01/18/2012 05:04 PM, Ben Hutchings wrote:
> >  There is harm.  You'll be blacklisting also the standard block device
> >  ioctls, and those won't work on 32-on-64 anymore.  A system with 32-bit
> >  userland will likely not boot anymore.
>
> It does (yes, I tested that myself now).  The standard block device
> ioctls are handled without calling the driver's compat_ioctl.

What about the non-compat path when done by non-root?

* Does BLKROSET still return EACCES when run by non-root and without 
CAP_SYS_ADMIN?  I suspect your patch is changing it to EINVAL.

* Does BLKFLSBUF work when run by non-root but with CAP_SYS_ADMIN?

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/