linux-kernel - Re: [RFC] fix devpts mount behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzwOU137V6wtyBjessx05NJo2G4KV0rvTKWvC79A+o9iQ@mail.gmail.com>
Date:	Mon, 23 Jan 2012 16:41:25 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Serge Hallyn <serge.hallyn@...onical.com>
Cc:	Dave Hansen <haveblue@...ibm.com>, sukadev@...ux.vnet.ibm.com,
	Andy Whitcroft <apw@...onical.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Matt Helsley <matthltc@...ibm.com>,
	linux-kernel@...r.kernel.org, containers@...ts.linux-foundation.org
Subject: Re: [RFC] fix devpts mount behavior

On Mon, Jan 23, 2012 at 4:25 PM, Serge Hallyn
<serge.hallyn@...onical.com> wrote:
>
> The only place that *might* be a problem is if initramsfs does a devpts
> mount, and later init blindly mounts tmpfs on /dev and mounts a new
> devpts.  But it seems unlikely there would be any open pty's so it
> shouldn't really matter.

Right. I think the opportunity for problems should be pretty small.

And it's not like the pty itself wouldn't continue to work - it's just
that programs like /usr/bin/tty wouldn't be able to *find* it.

Although who knows - maybe there is some other subtle interaction.

> I could go ahead and test that, say, ubuntu and fedora systems boot fine
> with this change.  But of course I can't be sure there is no userspace
> out there that won't cope...

I think the only way is to try it out.

If you can test a few distros and at least validate that the approach
isn't *totally* broken, I'll apply it. It's early days in the -rc
series yet, and this does seem to be one of those things that we'd be
better off trying to do early rather than delay.

If it causes problems, we will have to revert it and look for
alternate approaches, but if it just works it would seem to be the
right thing to do.

                          Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/