linux-kernel - Re: [RFC][PATCH 1/1] check for pci bar restore completion and retry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120124083659.0e2302b1@jbarnes-desktop>
Date:	Tue, 24 Jan 2012 08:36:59 -0800
From:	Jesse Barnes <jesse.barnes@...el.com>
To:	"Kay, Allen M" <allen.m.kay@...el.com>
Cc:	"linux-pci-owner@...r.kernel.org" <linux-pci-owner@...r.kernel.org>,
	"matt.wilcox@...el.com" <matt.wilcox@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jean.guyader@...citrix.com" <jean.guyader@...citrix.com>
Subject: Re: [RFC][PATCH 1/1] check for pci bar restore completion and retry

On Mon, 23 Jan 2012 15:55:55 -0800
"Kay, Allen M" <allen.m.kay@...el.com> wrote:

> On some OEM systems, pci_restore_state() is called while FLR has not yet
> completed.  As a result, PCI BAR register restore is not successful.  This fix
> reads back the restored value and compares it with saved value and re-tries
> 10 times before giving up.

But shouldn't we be doing this wait in the FLR code instead?

-- 
Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)