linux-kernel - Re: [GIT PULL] RCU changes for v3.3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327425208.7231.26.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Tue, 24 Jan 2012 18:13:28 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	paulmck@...ux.vnet.ibm.com
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] RCU changes for v3.3

Le mardi 24 janvier 2012 à 08:53 -0800, Paul E. McKenney a écrit :
> On Tue, Jan 24, 2012 at 05:25:12PM +0100, Eric Dumazet wrote:
> > Le jeudi 05 janvier 2012 à 14:54 +0100, Ingo Molnar a écrit :
> > > Linus,
> > > 
> > > Please pull the latest core-rcu-for-linus git tree from:
> > > 
> > >    git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-rcu-for-linus
> > > 
> > >  Thanks,
> > 
> > Hi guys
> > 
> > New lockdep warning here :
> 
> Hmmm...  Looks like tracing from within the inner idle loop.
> 
> Because RCU ignores CPUs in the inner idle loop (after the call to
> rcu_idle_enter()), RCU read-side critical sections are not legal there.
> 
> One approach would be to delay the call to rcu_idle_enter() until after
> the tracing is done, and to ensure that the call to rcu_idle_exit() happens
> before any tracing.  I am not seeing perf_trace_power(), so need to
> update and look again.  Or are you looking at -next rather than mainline?
> 

I am using mainline, not -next

It seems "powertop" triggers the warnings.

Check include/trace/events/power.h line 75 :

DECLARE_EVENT_CLASS(power,

This declares perf_trace_power()...

include/trace/ftrace.h line 718

#define DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print)  \
static notrace void							\
perf_trace_##call(void *__data, proto) ...


Thanks


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/