linux-kernel - Re: [PATCH 2/5] staging: tidspbridge: remove unused header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMP44s0YapTKw6tbz3mnYeBXu1Ut-fPahRNy8U3uSroo_zDWtA@mail.gmail.com>
Date:	Tue, 24 Jan 2012 19:45:08 +0200
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	Víctor Manuel Jáquez Leal 
	<vjaquez@...lia.com>
Cc:	Omar Ramirez Luna <omar.ramirez@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Armando Uribe <x0095078@...com>, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-omap@...r.kernel.org,
	Ernesto Ramos <ernesto@...com>,
	Rene Sapiens <rene.sapiens@...com>
Subject: Re: [PATCH 2/5] staging: tidspbridge: remove unused header

2012/1/23 Víctor Manuel Jáquez Leal <vjaquez@...lia.com>:
> No functional changes.
>
> The header file drv_interface.h was only used locally, hence there's no need
> to have it.
>
> Also the only prototyped functions were the file_operations callbacks, then
> this commit moves them up to avoid prototyping too.

'Also' is a keyword that usually denotes that we are talking about two
patches here: one that reshuffles the code, and another one that
removes the header.

But looks good to me either way.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/