linux-kernel - [PATCH 3/3] timer: Fix bad idle check on irq entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1327427984-23282-3-git-send-email-fweisbec@gmail.com>
Date:	Tue, 24 Jan 2012 18:59:44 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	John Stultz <john.stultz@...aro.org>
Subject: [PATCH 3/3] timer: Fix bad idle check on irq entry

idle_cpu() is called on irq entry to guess if
we need to call tick_check_idle(). This way we can
catch up with jiffies if the tick was stopped, stop
accounting idle time during the interrupt and maintain
the sched clock if it is unstable.

But if we are going to exit the idle loop to schedule
a new task (ie: if we have a task in the runqueue or a
remotely enqueued ttwu to perform), the idle_cpu() check
will return 0 such that we miss the call to tick_check_idle()
for all interrupts happening before we schedule the new task.

As a result these interrupts and the softirqs coming
along may deal with stale jiffies values, bad sched clock
values, and won't substract their time from the idle time
accounting.

Fix this with using is_idle_task() instead that strictly
checks that we are running the idle task, without caring
about the fact we are going to schedule a task soon.

Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: John Stultz <john.stultz@...aro.org>
---
 kernel/softirq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 4eb3a0f..5ace266 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -297,7 +297,7 @@ void irq_enter(void)
 	int cpu = smp_processor_id();

 	rcu_irq_enter();
-	if (idle_cpu(cpu) && !in_interrupt()) {
+	if (is_idle_task(current) && !in_interrupt()) {
 		/*
 		 * Prevent raise_softirq from needlessly waking up ksoftirqd
 		 * here, as softirq will be serviced on return from interrupt.
-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/