linux-kernel - Re: [PATCH] xfs: remove unecessary AIL push wakeups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120124180215.GC23671@infradead.org>
Date:	Tue, 24 Jan 2012 13:02:15 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	JiSheng Zhang <jszhang3@...l.ustc.edu.cn>
Cc:	xfs@....sgi.com, elder@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: remove unecessary AIL push wakeups

On Fri, Jan 13, 2012 at 01:30:28AM +0800, JiSheng Zhang wrote:
> 
> In commit 0030807c66("xfs: revert to using a kthread for AIL pushing"),
> AIL pushing is revert back to use a kthread. But unfortunately, it
> introduced a regression: there are unnecessary AIL push wakeups during
> idle, ~20 wakeups/s. This change remove the wakeups by reverting a bit
> more: set "tout" value as zero during idle.
> 
> Signed-off-by: JiSheng Zhang <jszhang3@...l.ustc.edu.cn>

Looks fine, although I'm a bit worried that I don't have the setup to
reproduce the issue that the patch addressed any more and we might
regress here.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/