linux-kernel - Re: linux-next: Tree for Jan 20 (drivers/media/radio/wl128x/)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdX8=x-=DQu0SCbqYK00+sP8a-kR=9KrUptAq-gqOXHAhA@mail.gmail.com>
Date:	Tue, 24 Jan 2012 22:33:43 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Randy Dunlap <rdunlap@...otime.net>,
	Fabio Estevam <festevam@...il.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Linux Media Mailing List <linux-media@...r.kernel.org>
Subject: Re: linux-next: Tree for Jan 20 (drivers/media/radio/wl128x/)

On Sat, Jan 21, 2012 at 01:32, Randy Dunlap <rdunlap@...otime.net> wrote:
> On 01/19/2012 06:12 PM, Stephen Rothwell wrote:
>> Changes since 20120119:
>
> on x86_64:
>
> ERROR: "st_register" [drivers/media/radio/wl128x/fm_drv.ko] undefined!
> ERROR: "st_unregister" [drivers/media/radio/wl128x/fm_drv.ko] undefined!

Also in m68k allmodconfig since a while:
http://kisskb.ellerman.id.au/kisskb/buildresult/5427875/

config RADIO_WL128X
        tristate "Texas Instruments WL128x FM Radio"
        depends on VIDEO_V4L2 && RFKILL
        select TI_ST if NET && GPIOLIB

config TI_ST
        tristate "Shared transport core driver"
        depends on NET && GPIOLIB
        select FW_LOADER

On m68k allmodconfig, GPIOLIB is not enabled, hence TI_ST
will not be selected, and st_{,un}register() won't be there.
Shouldn't the whole RADIO_WL128X depend on NET && GPIOLIB?
Or depend on TI_ST, instead of selecting it?

BTW, shouldn't it be called ti_st_un{,un}register()?
At first I thought the link error was related to SCSI tape drives ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/