[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4F1F24DD.5030904@gmail.com>
Date: Tue, 24 Jan 2012 15:38:37 -0600
From: Rob Herring <robherring2@...il.com>
To: Grant Likely <grant.likely@...retlab.ca>
CC: linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
devicetree-discuss@...ts.ozlabs.org,
Milton Miller <miltonm@....com>, benh@...nel.crashing.org,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RFCv2 03/14] irq_domain: Make irq_domain structure match powerpc's
irq_host
On 01/23/2012 03:07 PM, Grant Likely wrote:
> Part of the series to unify the irq remapping mechanisms in the
> kernel. A follow up patch will copy the powerpc implementation into
> kernel/irq/irqdomain.c, which will be a lot easier if the structures
> are identical.
>
> Where they differ, I've chose to use the powerpc names since there is
> a lot more code using those names.
>
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
> ---
> arch/arm/common/gic.c | 14 ++++----
> include/linux/irqdomain.h | 84 ++++++++++++++++++++++++++++++++++-----------
> kernel/irq/irqdomain.c | 14 ++++----
> 3 files changed, 78 insertions(+), 34 deletions(-)
>
snip...
> @@ -126,7 +126,7 @@ void irq_dispose_mapping(unsigned int irq)
> }
> EXPORT_SYMBOL_GPL(irq_dispose_mapping);
>
> -int irq_domain_simple_dt_translate(struct irq_domain *d,
> +int irq_domain_simple_xlate(struct irq_domain *d,
> struct device_node *controller,
> const u32 *intspec, unsigned int intsize,
> unsigned long *out_hwirq, unsigned int *out_type)
This needs a declaration in irqdomain.h (as well as EXPORT?). There
could be others as well, but this is the one I'm using for generic irq chip.
Rob
> @@ -181,7 +181,7 @@ EXPORT_SYMBOL_GPL(irq_domain_generate_simple);
>
> struct irq_domain_ops irq_domain_simple_ops = {
> #ifdef CONFIG_OF_IRQ
> - .dt_translate = irq_domain_simple_dt_translate,
> + .xlate = irq_domain_simple_xlate,
> #endif /* CONFIG_OF_IRQ */
> };
> EXPORT_SYMBOL_GPL(irq_domain_simple_ops);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists