linux-kernel - Re: [PATCH] Support single byte reads from integers published in procfs by kernel/sysctl.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120124145037.f8223e37.akpm@linux-foundation.org>
Date:	Tue, 24 Jan 2012 14:50:37 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Earl Chew <echew@...acom.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Eric Paris <eparis@...hat.com>,
	"Serge E. Hallyn" <serge.hallyn@...onical.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<adobriyan@...il.com>
Subject: Re: [PATCH] Support single byte reads from integers published in
 procfs by kernel/sysctl.c

On Mon, 23 Jan 2012 08:47:51 -0800
Earl Chew <echew@...acom.com> wrote:

> > Rereading different bytes of the integer multiple times when the integer
> > may be changing does not seem like a reasonable implementation.
> 
> Yes. I agree with you. I shall re-work the patch as per your suggestion.

Yes, this is a bug and procfs should support byte-at-a-time reading of these
strings.  And yes, they are strings!  Of digits.

We fixed an instance of this in procfs a while ago (maybe a year ago?).
But I forget where it was.  It is surprising that a bug of this nature
survived so long.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/