linux-kernel - Re: [PATCH] debugfs: add mode, uid and gid options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120124235734.GA28585@kroah.com>
Date:	Tue, 24 Jan 2012 15:57:34 -0800
From:	Greg KH <greg@...ah.com>
To:	Ludwig Nussel <ludwig.nussel@...e.de>
Cc:	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] debugfs: add mode, uid and gid options

On Mon, Jan 16, 2012 at 05:06:21PM +0100, Ludwig Nussel wrote:
> Cautious admins may want to restrict access to debugfs. Currently a
> manual chown/chmod e.g. in an init script is needed to achieve that.
> Distributions that want to make the mount options configurable need
> to add extra config files. By allowing to set the root inode's uid,
> gid and mode via mount options no such hacks are needed anymore.
> Instead configuration becomes straight forward via fstab.
> 
> Signed-off-by: Ludwig Nussel <ludwig.nussel@...e.de>

Oops, no, I didn't apply this as I get a compiler warning with it
applied:

fs/debugfs/inode.c:244:2: warning: initialization from incompatible pointer type [enabled by default]
fs/debugfs/inode.c:244:2: warning: (near initialization for ‘debugfs_super_operations.show_options’) [enabled by default]

Please fix this and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/