linux-kernel - Re: [PATCH v2 2/2] regulator: add device tree support for max8997

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120125112602.GB2991@opensource.wolfsonmicro.com>
Date:	Wed, 25 Jan 2012 11:26:02 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Karol Lewandowski <k.lewandowsk@...sung.com>
Cc:	Thomas Abraham <thomas.abraham@...aro.org>,
	linux-kernel@...r.kernel.org, rpurdie@...ys.net,
	rob.herring@...xeda.com, grant.likely@...retlab.ca,
	kgene.kim@...sung.com, myungjoo.ham@...sung.com,
	kyungmin.park@...sung.com, dg77.kim@...sung.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, Rajendra Nayak <rnayak@...com>
Subject: Re: [PATCH v2 2/2] regulator: add device tree support for max8997

On Wed, Jan 25, 2012 at 10:55:49AM +0100, Karol Lewandowski wrote:
> On 12.01.2012 08:35, Thomas Abraham wrote:
> >Add device tree based discovery support for max8997.
> 
> >+	pdata->regulators = rdata;
> >+	for_each_child_of_node(regulators_np, reg_np) {
> >+		for (i = 0; i<  ARRAY_SIZE(regulators); i++)
> >+			if (!of_node_cmp(reg_np->name, regulators[i].name))
> >+				break;
> >+		rdata->id = i;
> >+		rdata->initdata = of_get_regulator_init_data(
> >+						iodev->dev, reg_np);

> One more thing - of_get_regulator_init_data() will set apply_uV to 1
> so we need to reset it for BUCK6, which doesn't provide
> set_voltage() ops, like:

> 	if (rdata->initdata && regulators[i].id == MAX8997_BUCK6)
> 		rdata->initdata->constraints.apply_uV = 0;

So, over in the other thready you were referring to mailing list posts
you made in the past few moments as examples of past issues.  Please at
least mention that there hasn't been any actual discussion when doing
this...

I don't see a problem here, if the device can't set the voltage then
setting constraints to allow the voltage to be changed is silly and the
user just shouldn't do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/