linux-kernel - Re: [PATCH] regulator: Set apply_uV only when min and max voltages are defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120125113940.GD3687@opensource.wolfsonmicro.com>
Date:	Wed, 25 Jan 2012 11:39:41 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Karol Lewandowski <k.lewandowsk@...sung.com>
Cc:	linux-kernel@...r.kernel.org, m.szyprowski@...sung.com,
	s.nawrocki@...sung.com, lrg@...com,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Thomas Abraham <thomas.abraham@...aro.org>
Subject: Re: [PATCH] regulator: Set apply_uV only when min and max voltages
 are defined

On Wed, Jan 25, 2012 at 10:31:45AM +0100, Karol Lewandowski wrote:
> apply_uV is errornously set when regulator is instantiated from device
> tree, even when it doesn't contain any voltage constraints.

Applied, thanks.  But really

> -	if (constraints->min_uV == constraints->max_uV)
> +	if (min_uV && max_uV && constraints->min_uV == constraints->max_uV)

we only actually need to check one of min_uV and max_uV due to the
equality check.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)