[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120125125020.GI3687@opensource.wolfsonmicro.com>
Date: Wed, 25 Jan 2012 12:50:20 +0000
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@...dia.com>
Cc: "lrg@...com" <lrg@...com>,
"jedu@...mlogic.co.uk" <jedu@...mlogic.co.uk>,
"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH V2] regulator: tps65910: Sleep control through external
inputs
On Wed, Jan 25, 2012 at 06:17:43PM +0530, Laxman Dewangan wrote:
> On Wednesday 25 January 2012 06:12 PM, Mark Brown wrote:
> >This really isn't what the set_mode() API is for - especially the fact
> >that it supports turning the regulator off which really isn't what
> >set_mode() is supposed to do. A generic driver using this API isn't
> >going to play too well.
> Then what should be the method? Is it through the macro similar to
> patch V1 where LOW_POWER mode option come from platform data? The
> idea is to set the regulator in OFF or low power mode based on
> external control.
Like I said we've got the various suspend callbacks for setting the
behaviour in suspend mode.
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists