linux-kernel - Re: Removal of unwanted comment in hrtimer structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1201251512520.2716@ionos>
Date:	Wed, 25 Jan 2012 15:16:21 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Namit Gupta <namit2010@...il.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: Removal of unwanted comment in hrtimer structure

On Mon, 23 Jan 2012, Namit Gupta wrote:

> Dear Mr Thomas Gleixner,
> 
> While working on hrtimer, I found that the "_expires" field has been
> removed in latest kernel (kernel 3.x). but the comment written for
> "_expires" has yet not been removed.

There is no comment for the _expires field. The comment talks about
node and the struct element node.expires which replaced _expires, but
still has the same semantics as the old _expires field. So the comment
is correct and stays.

>  /**
>   * struct hrtimer - the basic hrtimer structure
> - * @node: timerqueue node, which also manages node.expires,
> - * the absolute expiry time in the hrtimers internal
> - * representation. The time is related to the clock on
> - * which the timer is based. Is setup by adding
> - * slack to the _softexpires value. For non range timers
> - * identical to _softexpires.
> + * @node: timerqueue node, which also manages node

Aside of that this comment is wrong and pointless. It says:

      @A: bla A, which also manages A

Pretty useless.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/