linux-kernel - Re: [PATCH 1/2] Staging; bcm/CmHost.c: Style cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120125062658.GR3294@mwanda>
Date:	Wed, 25 Jan 2012 09:26:58 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Ilia Mirkin <imirkin@...m.mit.edu>,
	linux-kernel@...r.kernel.org,
	"Justin P. Mattock" <justinmattock@...il.com>
Subject: Re: [PATCH 1/2] Staging; bcm/CmHost.c: Style cleanup

This is probably going to need to be redone on top of the other bcm
cleanup patches anyway.

On Tue, Jan 24, 2012 at 11:46:31PM +0100, Jesper Juhl wrote:
> +		pstClassifierEntry->ucDestPortRangeLength
> +			= psfCSType->cCPacketClassificationRule.u8ProtocolDestPortRangeLength/4;

Put the equals on the first line when you break something up like
this. Also the real fix here is to choose shorter and better names
than "cCPacketClassificationRule.u8ProtocolDestPortRangeLength".

If you're breaking up a condition normally the && or || go on the
first line as well.
	if (foo &&
	    bar &&
	    baz) { ...

Although that's not in CodingStyle so it's not a "redo the patch"
situation.

regards,
dan carpenter

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)