linux-kernel - Re: [GIT PULL] MCE recovery changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120126104646.GF3853@elte.hu>
Date:	Thu, 26 Jan 2012 11:46:46 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	linux-kernel@...r.kernel.org, Borislav Petkov <bp@...64.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [GIT PULL] MCE recovery changes


* Luck, Tony <tony.luck@...el.com> wrote:

> Ingo,
> 
> Time to move these from "ras" tree to "tip" so they will be nicely
> seasoned for the 3.4 merge window.
> 
> I tried to follow the instructions in
>  http://git-blame.blogspot.com/2012/01/using-signed-tag-in-pull-requests.html
> to use the fancy new signed tag scheme. If something is wrong here, then it
> is most likely that I typoed (or thinkoed) while following them.

It worked perfectly.

> 
> -Tony
> 
> The following changes since commit dc47ce90c3a822cd7c9e9339fe4d5f61dcb26b50:
> 
>   Linux 3.2-rc5 (2011-12-09 15:09:32 -0800)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git mce-recovery-for-tip
> 
> for you to fetch changes up to 5f7b88d51e89771f64c15903b96b5933dd0bc6d8:
> 
>   x86/mce: Recognise machine check bank signature for data path error (2012-01-03 12:07:07 -0800)
> 
> ----------------------------------------------------------------
> MCE recovery (data path only)
> 
> ----------------------------------------------------------------
> Tony Luck (6):
>       HWPOISON: Clean up memory_failure() vs. __memory_failure()
>       HWPOISON: Add code to handle "action required" errors.
>       x86/mce: Create helper function to save addr/misc when needed
>       x86/mce: Add mechanism to safely save information in MCE handler
>       x86/mce: Handle "action required" errors
>       x86/mce: Recognise machine check bank signature for data path error
> 
>  arch/x86/kernel/cpu/mcheck/mce-severity.c |   16 +++-
>  arch/x86/kernel/cpu/mcheck/mce.c          |  179 ++++++++++++++++++++---------
>  drivers/base/memory.c                     |    2 +-
>  include/linux/mm.h                        |    4 +-
>  mm/hwpoison-inject.c                      |    4 +-
>  mm/madvise.c                              |    2 +-
>  mm/memory-failure.c                       |   96 ++++++++--------
>  7 files changed, 197 insertions(+), 106 deletions(-)

Pulled, thanks!

One thing i noticed was the magic constant 0x134:

+               SER, MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCI_ADDR|MCACOD, MCI_UC_SAR|MCI_ADDR|0x0134),

don't we want that defined a bit more clearly?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/