linux-kernel - Re: [PATCH] dmaengine: dmatest: fix thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F21780F.7060504@atmel.com>
Date:	Thu, 26 Jan 2012 16:58:07 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Danny Kukawka <danny.kukawka@...ect.de>
CC:	linux-kernel@...r.kernel.org,
	Haavard Skinnemoen <hskinnemoen@...il.com>,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] dmaengine: dmatest: fix thread_count

On 01/26/2012 04:33 PM, Danny Kukawka :
> It seems with commit f1aef8b6e6abf32a3a269542f95a19e2cb319f6c
> another case where thread_count wasn't calculated correctly
> has been overlooked.
> 
> This fix also a -Wparentheses compiler warning.
> 
> Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de>

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

> ---
>  drivers/dma/dmatest.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index 2b8661b..24225f0 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -599,7 +599,7 @@ static int dmatest_add_channel(struct dma_chan *chan)
>  	}
>  	if (dma_has_cap(DMA_PQ, dma_dev->cap_mask)) {
>  		cnt = dmatest_add_threads(dtc, DMA_PQ);
> -		thread_count += cnt > 0 ?: 0;
> +		thread_count += cnt > 0 ? cnt : 0;
>  	}
>  
>  	pr_info("dmatest: Started %u threads using %s\n",


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/