linux-kernel - RE: [PATCH] scripts: dtc: fix compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Jan 2012 08:58:31 -0800
From:	Stephen Warren <swarren@...dia.com>
To:	Felipe Balbi <balbi@...com>,
	"David Gibson (david@...son.dropbear.id.au)" 
	<david@...son.dropbear.id.au>, "jdl@....com" <jdl@....com>
CC:	"mmarek@...e.cz" <mmarek@...e.cz>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>
Subject: RE: [PATCH] scripts: dtc: fix compile warnings

Felipe Balbi wrote at Thursday, January 26, 2012 4:20 AM:
> Fix following compile warnings:
> 
> scripts/dtc/flattree.c: In function ‘flat_read_mem_reserve’:
> scripts/dtc/flattree.c:700:14: warning: variable ‘p’ set but not used
> 	[-Wunused-but-set-variable]
> 
> scripts/dtc/dtc.c: In function ‘main’:
> scripts/dtc/dtc.c:104:17: warning: variable ‘check’ set but not used
> 	[-Wunused-but-set-variable]
> 
> Signed-off-by: Felipe Balbi <balbi@...com>

I think you want to send this to the upstream dtc maintainers; I've CC'd
them on this mail.

> ---
>  scripts/dtc/dtc.c      |    5 +----
>  scripts/dtc/flattree.c |    2 --
>  2 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/scripts/dtc/dtc.c b/scripts/dtc/dtc.c
> index 451c92d..2ef5e2e 100644
> --- a/scripts/dtc/dtc.c
> +++ b/scripts/dtc/dtc.c
> @@ -101,7 +101,7 @@ int main(int argc, char *argv[])
>  	const char *outform = "dts";
>  	const char *outname = "-";
>  	const char *depname = NULL;
> -	int force = 0, check = 0, sort = 0;
> +	int force = 0, sort = 0;
>  	const char *arg;
>  	int opt;
>  	FILE *outf = NULL;
> @@ -143,9 +143,6 @@ int main(int argc, char *argv[])
>  		case 'f':
>  			force = 1;
>  			break;
> -		case 'c':
> -			check = 1;
> -			break;
>  		case 'q':
>  			quiet++;
>  			break;
> diff --git a/scripts/dtc/flattree.c b/scripts/dtc/flattree.c
> index ead0332..28d0b23 100644
> --- a/scripts/dtc/flattree.c
> +++ b/scripts/dtc/flattree.c
> @@ -697,7 +697,6 @@ static struct reserve_info *flat_read_mem_reserve(struct inbuf *inb)
>  {
>  	struct reserve_info *reservelist = NULL;
>  	struct reserve_info *new;
> -	const char *p;
>  	struct fdt_reserve_entry re;
> 
>  	/*
> @@ -706,7 +705,6 @@ static struct reserve_info *flat_read_mem_reserve(struct inbuf *inb)
>  	 *
>  	 * First pass, count entries.
>  	 */
> -	p = inb->ptr;
>  	while (1) {
>  		flat_read_chunk(inb, &re, sizeof(re));
>  		re.address  = fdt64_to_cpu(re.address);
> --
> 1.7.8.2

-- 
nvpublic