[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4F219AF2.6070108@freescale.com>
Date: Thu, 26 Jan 2012 12:26:58 -0600
From: Scott Wood <scottwood@...escale.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC: Joerg Roedel <joerg.roedel@....com>,
<iommu@...ts.linux-foundation.org>, <linux-kernel@...r.kernel.org>,
Ohad Ben-Cohen <ohad@...ery.com>,
David Woodhouse <dwmw2@...radead.org>,
David Brown <davidb@...eaurora.org>,
Tony Lindgren <tony@...mide.com>,
Stuart Yoder <b08248@...il.com>,
Hiroshi Doyu <hdoyu@...dia.com>
Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
On 01/19/2012 10:27 AM, Laurent Pinchart wrote:
> Hi Joerg,
>
> On Thursday 19 January 2012 17:07:39 Joerg Roedel wrote:
>> On Thu, Jan 19, 2012 at 04:46:13PM +0100, Laurent Pinchart wrote:
>>>> +struct iommu_domain_geometry {
>>>> + u64 aperture_start; /* First address that can be mapped */
>>>> + u64 aperture_end; /* Last address that can be mapped */
>>>
>>> Would it make sense to use a platform-dependent type that represents
>>> physical addresses instead of u64 ?
>>
>> Well, u64 is a catch-all datatype which should suit all drivers. Is this
>> a problem at ARM?
>
> No, it's not a problem for ARM, at least to my knowledge. It just struck me as
> weird, as we have specific data types for other kinds of addresses (such as
> dma_addr_t).
If we want to be able to expose these attribute structs to userspace via
vfio, we'll want to stick with fixed size types.
-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists