| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Jan 2012 19:28:42 +0100 From: Ingo Molnar <mingo@...e.hu> To: Tony Luck <tony.luck@...el.com> Cc: linux-kernel@...r.kernel.org, Borislav Petkov <bp@...64.org>, Thomas Gleixner <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com> Subject: Re: [GIT PULL] MCE recovery changes * Tony Luck <tony.luck@...el.com> wrote: > On Thu, Jan 26, 2012 at 2:46 AM, Ingo Molnar <mingo@...e.hu> wrote: > > It worked perfectly. > > Hurrah! > > > Pulled, thanks! > > Thank you. > > > One thing i noticed was the magic constant 0x134: > > > > + SER, MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCI_ADDR|MCACOD, MCI_UC_SAR|MCI_ADDR|0x0134), > > > > don't we want that defined a bit more clearly? > > Stylistically it is compatible with the existing: > MASK(MCI_STATUS_OVER|MCI_UC_SAR|0xfff0, MCI_UC_S|0x00c0) > and > MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCACOD, MCI_UC_S|0x017a) > > ... but that's just a sign that they need some love too :-) > > I'll see what I can do - but meaningful names will clearly be > longer than the hex constants that they replace - and I'm > already pushing line length limits here, so it will need more > than a trivial restructure. Well, one option is to let the line grow - for such things it's ok up to 100 cols or so. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists