[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120126182829.GB22334@kroah.com>
Date: Thu, 26 Jan 2012 10:28:29 -0800
From: Greg KH <greg@...ah.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: Ben Hutchings <ben@...adent.org.uk>, stable@...r.kernel.org,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org, Petr Matousek <pmatouse@...hat.com>,
linux-scsi@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
James Bottomley <JBottomley@...allels.com>
Subject: Re: [PATCH stable 3/4] block: fail SCSI passthrough ioctls on
partition devices
On Wed, Jan 25, 2012 at 04:19:26PM -0800, Greg KH wrote:
> On Tue, Jan 24, 2012 at 01:56:10PM +0100, Paolo Bonzini wrote:
> > On 01/18/2012 05:04 PM, Ben Hutchings wrote:
> > >> There is harm. You'll be blacklisting also the standard block device
> > >> ioctls, and those won't work on 32-on-64 anymore. A system with 32-bit
> > >> userland will likely not boot anymore.
> > >
> > >It does (yes, I tested that myself now). The standard block device
> > >ioctls are handled without calling the driver's compat_ioctl.
> >
> > What about the non-compat path when done by non-root?
> >
> > * Does BLKROSET still return EACCES when run by non-root and without
> > CAP_SYS_ADMIN? I suspect your patch is changing it to EINVAL.
> >
> > * Does BLKFLSBUF work when run by non-root but with CAP_SYS_ADMIN?
>
> I'm confused here as well.
>
> Can someone please send me the proper patch that I need to apply to
> resolve this issue on the 2.6.32.y kernel?
Ok, I think I've queued up the correct ones, please let me know if I
messed something up.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists