linux-kernel - Re: [RFC][PATCH] tracing/module: Move tracepoint out of module.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120126183946.GA14709@elte.hu>
Date:	Thu, 26 Jan 2012 19:39:46 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Li Zefan <lizf@...fujitsu.com>
Subject: Re: [RFC][PATCH] tracing/module: Move tracepoint out of module.h


* Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu, 2012-01-26 at 09:04 -0500, Steven Rostedt wrote:
> > [ Added Li who added the original tracepoint ]
> > 
> > On Thu, 2012-01-26 at 14:55 +0100, Ingo Molnar wrote:
> > > * Steven Rostedt <rostedt@...dmis.org> wrote:
> > > 
> > > > On Thu, 2012-01-26 at 11:28 +0100, Ingo Molnar wrote:
> > > > 
> > > > > How much more do we save if we move all of try_module_get() out 
> > > > > of line? It still seems a rather thick inline function with 
> > > > > preempt section and all. I'd *really* suggest that it should all 
> > > > > be uninlined.
> > > > > 
> > > > 
> > > > Here's the #'s
> > > > 
> > > >    text	   data	    bss	    dec	    hex	filename
> > > > 7489488	2249584	9719808	19458880	128eb40	vmlinux-prepatch
> > > >    text	   data	    bss	    dec	    hex	filename
> > > > 7482458	2248048	9719808	19450314	128c9ca	vmlinux-postpatch
> > > >    text	   data	    bss	    dec	    hex	filename
> > > > 7477393	2248080	9719808	19445281	128b621	vmlinux-updatedpatch
> 
> 
> New numbers:
> 
>    text	   data	    bss	    dec	    hex	filename
> 7476509	2248048	9719808	19444365	128b28d	vmlinux-updatedpatch2
> 
> Just 916 bytes savings more. But gets rid of the hot path changes.
> 
> New patch below: (and the IP still works)

Ok, i like this one best. Rusty, does it look good to you too?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/