linux-kernel - Re: [patch v2, kernel 3.2.1] RTNETLINK adjusting values of min_ifinfo_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120126.163725.208323115932061885.davem@davemloft.net>
Date:	Thu, 26 Jan 2012 16:37:25 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	steweg@...t.sk
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch v2, kernel 3.2.1] RTNETLINK adjusting values of
 min_ifinfo_dump_size

From: Stefan Gula <steweg@...t.sk>
Date: Thu, 26 Jan 2012 22:01:06 +0100 (CET)

> From: Stefan Gula <steweg@...il.com>
> 
> Setting link parameters on a netdevice changes the value
> of if_nlmsg_size(), therefore it is necessary to recalculate
> min_ifinfo_dump_size.
> 
> Signed-off-by: Stefan Gula <steweg@...il.com>

Applied, but:

> +	min_ifinfo_dump_size = max_t(u16, if_nlmsg_size(dev),
> +					min_ifinfo_dump_size);
> +

The second line is not properly indented, the first non-space
character should line up with the first column after the
openning parenthesis on the previous line.

I fixed this up, but really this was a lot of tooth pulling to
get you to post this patch correctly.  You cannot consume this
much maintainer and reviewer resources in the future.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/