[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJd=RBCv1F3oWpnEbqrvOaRzg_G6Xj_PPHP8v6OADL=vH2pt8g@mail.gmail.com>
Date: Thu, 26 Jan 2012 11:19:17 +0800
From: Hillf Danton <dhillf@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-mm@...ck.org,
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
Hugh Dickins <hughd@...gle.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: vmscan: fix malused nr_reclaimed in shrinking zone
Hi Andrew
On Thu, Jan 26, 2012 at 9:00 AM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
>
> I'm thinking we have a bit of code rot happening here. This comment:
>
> /*
> * On large memory systems, scan >> priority can become
> * really large. This is fine for the starting priority;
> * we want to put equal scanning pressure on each zone.
> * However, if the VM has a harder time of freeing pages,
> * with multiple processes reclaiming pages, the total
> * freeing target can get unreasonably large.
> */
>
> seems to have little to do with the code which it is trying to
> describe. Or at least, I'm not sure this is the best we can possibly
> do :(
>
Try to do it soon 8-)
>
> Also, your email client is adding MIME goop to the emails which mine
> (sylpheed) is unable to decrypt. It turns "=" into "=3D" everywhere.
> This:
>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: quoted-printable
>
> I blame sylpheed for this, but if you can make it stop, that would make
> my life easier, and perhaps others.
>
More care will take gmail later on.
Thanks
Hillf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists