[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <m1liouc90h.fsf@fess.ebiederm.org>
Date: Thu, 26 Jan 2012 15:57:18 -0800
From: ebiederm@...ssion.com (Eric W. Biederman)
To: David Miller <davem@...emloft.net>
Cc: eric.dumazet@...il.com, xemul@...allels.com,
sjur.brandeland@...ricsson.com, levinsasha928@...il.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
davej@...hat.com, sjurbren@...il.com
Subject: Re: [PATCH] netns: fix net_alloc_generic()
David Miller <davem@...emloft.net> writes:
> From: ebiederm@...ssion.com (Eric W. Biederman)
> Date: Thu, 26 Jan 2012 14:57:02 -0800
>
>> It is not a chicken and egg problem. It is a bug in caif.
>> caif is claiming to be a network device when it is acting as a subsytem.
>> That means it is being initialized too late.
>>
>> Untested but this should trivially fix the problem, and a bunch
>> of others of the same ilk.
>>
>> It is not safe to shutdown subsystems until all of the devices
>> are gone, otherwise there will be problems with packets in flight.
>
> If you guys can agree that this is the better fix, and we can
> get testing showing that it works, I'll revert Eric D.'s patch
> and apply the final version of this one.
Eric D.'s change is correct, but it is just an optimization of
net_assign_generic. Eric D.'s change is not a bug fix.
Tested fix in a moment.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists