[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdaRojO2P8FrVFygA16DazGdFj05eXqZjX7oJS2QT4qfZQ@mail.gmail.com>
Date: Thu, 26 Jan 2012 07:34:36 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Viresh Kumar <viresh.kumar@...com>,
Christopher BLAIR <chris.blair@...ricsson.com>
Cc: Linus WALLEIJ <linus.walleij@...ricsson.com>,
Samuel Ortiz <sameo@...ux.intel.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH v2] gpio/stmpe: support no-irq mode
On Wed, Jan 25, 2012 at 11:35 AM, Viresh Kumar <viresh.kumar@...com> wrote:
> On 1/25/2012 3:23 PM, Linus WALLEIJ wrote:
>> + if (!stmpe->pdata->no_irq) {
>> + irq = platform_get_irq(pdev, 0);
>> + if (irq < 0)
>> + return irq;
>> + }
>
> I already acked it once, but there is another idea that i have :)
> Why not allow passing no irqs in resource fields directly.
>
> i.e. platform_get_irq() < 0 will automatically mean irqs are not supported
> on platform and then we can do what we are doing in your patch. This will
> remove need of another pdata field. :)
Hm sounds intuitively elegant! Chris, do you want to have a go
at it?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists