lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Jan 2012 10:54:48 +0200 From: "Kirill A. Shutemov" <kirill@...temov.name> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Michal Hocko <mhocko@...e.cz>, Li Zefan <lizf@...fujitsu.com>, linux-mm@...ck.org, "bsingharora@...il.com" <bsingharora@...il.com>, Hiroyuki KAMEZAWA <kamezawa.hiroyu@...fujitsu.com>, Johannes Weiner <hannes@...xchg.org>, Cgroups <cgroups@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] memcg: fix compile warning on non-numa systems On Thu, Jan 26, 2012 at 12:55:21AM -0800, Andrew Morton wrote: > On Mon, 16 Jan 2012 09:47:15 +0100 Michal Hocko <mhocko@...e.cz> wrote: > > > On Mon 16-01-12 14:04:53, Li Zefan wrote: > > > Fix this warning: > > > > > > CC mm/memcontrol.o > > > mm/memcontrol.c: In function 'memcg_check_events': > > > mm/memcontrol.c:779:22: warning: unused variable 'do_numainfo' > > > > This has been already posted by Kirill and I didn't like the solution > > (https://lkml.org/lkml/2011/12/27/86). He then reposted with a different > > version (https://lkml.org/lkml/2012/1/6/281). > > The later one looks better but I still think this is not worth > > complicate the code just to get rid of this warning. > > This? > > --- a/mm/memcontrol.c~a > +++ a/mm/memcontrol.c > @@ -776,7 +776,8 @@ static void memcg_check_events(struct me > /* threshold event is triggered in finer grain than soft limit */ > if (unlikely(mem_cgroup_event_ratelimit(memcg, > MEM_CGROUP_TARGET_THRESH))) { > - bool do_softlimit, do_numainfo; > + bool do_softlimit; > + bool do_numainfo __maybe_unused; > > do_softlimit = mem_cgroup_event_ratelimit(memcg, > MEM_CGROUP_TARGET_SOFTLIMIT); > _ Acked-by: Kirill A. Shutemov <kirill@...temov.name> -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists