linux-kernel - Re: [PATCH 07/13] perf_events: implement PERF_SAMPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F2240DD.9050006@linux.vnet.ibm.com>
Date:	Fri, 27 Jan 2012 11:44:53 +0530
From:	Anshuman Khandual <khandual@...ux.vnet.ibm.com>
To:	Stephane Eranian <eranian@...gle.com>
CC:	linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
	acme@...radead.org, robert.richter@....com, ming.m.lin@...el.com,
	andi@...stfloor.org, asharma@...com, ravitillo@....gov,
	vweaver1@...s.utk.edu
Subject: Re: [PATCH 07/13] perf_events: implement PERF_SAMPLE_BRANCH for Intel
 X86 (v3)

On Monday 09 January 2012 10:19 PM, Stephane Eranian wrote:
> This patch implements PERF_SAMPLE_BRANCH support for Intel
> X86 processors. It connects PERF_SAMPLE_BRANCH to the actual LBR.
> 
> The patch adds the hooks in the PMU irq handler to save the LBR
> on counter overflow for both regular and PEBS modes.
> 
> Signed-off-by: Stephane Eranian <eranian@...gle.com>
> ---
>  arch/x86/kernel/cpu/perf_event_intel.c     |   35 +++++++++++++
>  arch/x86/kernel/cpu/perf_event_intel_ds.c  |   10 ++--
>  arch/x86/kernel/cpu/perf_event_intel_lbr.c |   73 +++++++++++++++++++++++++++-
>  include/linux/perf_event.h                 |    3 +
>  4 files changed, 113 insertions(+), 8 deletions(-)
> 
This patch FAILs to compile independently because of the function
'intel_pmu_setup_lbr_filter' which is defined arch/x86/kernel/
cpu/perf_event_intel_lbr.c but used in arch/x86/kernel/cpu
/perf_event_intel.c without making the prototype update in
the header arch/x86/kernel/cpu/perf_event.h. Though [PATCH 8/13]
rectifies the problem, [PATCH 7/13] fails to compile independently.

arch/x86/kernel/cpu/perf_event_intel_lbr.c:291: warning: ‘intel_pmu_setup_lbr_filter’ defined but not used
  CC      arch/x86/kernel/cpu/perf_event_intel_ds.o
  CC      arch/x86/kernel/cpu/perf_event_intel.o
arch/x86/kernel/cpu/perf_event_intel.c: In function ‘intel_pmu_hw_config’:
arch/x86/kernel/cpu/perf_event_intel.c:1342: error: implicit declaration of function ‘intel_pmu_setup_lbr_filter’
make[3]: *** [arch/x86/kernel/cpu/perf_event_intel.o] Error 1
make[2]: *** [arch/x86/kernel/cpu] Error 2
make[1]: *** [arch/x86/kernel] Error 2
make: *** [arch/x86] Error 2

-- 
Linux Technology Centre
IBM Systems and Technology Group
Bangalore India

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/