linux-kernel - Re: [RFC PATCH v1 1/2] sched: unified sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120127091640.GB8897@dirshya.in.ibm.com>
Date:	Fri, 27 Jan 2012 14:46:40 +0530
From:	Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Vincent Guittot <vincent.guittot@...aro.org>,
	Indan Zupancic <indan@....nu>,
	Youquan Song <youquan.song@...el.com>,
	Ingo Molnar <mingo@...e.hu>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v1 1/2] sched: unified sched_powersavings sysfs
 tunable

* Peter Zijlstra <a.p.zijlstra@...llo.nl> [2012-01-25 15:57:26]:

> On Mon, 2012-01-16 at 21:52 +0530, Vaidyanathan Srinivasan wrote:
> > +enum powersavings_level {
> > +       POWERSAVINGS_DISABLED = 0,      /* Max performance */
> > +       POWERSAVINGS_DEFAULT,           /* Kernel default policy, automatic powersave */
> > +                                       /* vs performance tradeoff */
> > +       POWERSAVINGS_MAX                /* Favour power savings over peformance */
> >  }; 
> 
> I don't like that, I can get, OFF, AUTO, ON, but to overload that with
> different policies for AUTO and ON just reeks.

How about this:

enum powersavings_level {
       POWERSAVINGS_OFF = 0,           /* Max performance */
       POWERSAVINGS_AUTO,              /* Kernel default policy, automatic powersave */
                                       /* vs performance tradeoff */
       POWERSAVINGS_ON                 /* Max power savings */
}; 
 
Basically AUTO is where we have a 'policy' or heuristics, but simple
straight forward decisions for OFF and ON case. 

--Vaidy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/