linux-kernel - Re: [RFC PATCH v1 1/2] sched: unified sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120127093514.GD8897@dirshya.in.ibm.com>
Date:	Fri, 27 Jan 2012 15:05:14 +0530
From:	Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Vincent Guittot <vincent.guittot@...aro.org>,
	Indan Zupancic <indan@....nu>,
	Youquan Song <youquan.song@...el.com>,
	Ingo Molnar <mingo@...e.hu>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Jens Axboe <axboe@...nel.dk>
Subject: Re: [RFC PATCH v1 1/2] sched: unified sched_powersavings sysfs
 tunable

* Peter Zijlstra <a.p.zijlstra@...llo.nl> [2012-01-25 15:53:01]:

> On Mon, 2012-01-16 at 21:52 +0530, Vaidyanathan Srinivasan wrote:
> > +++ b/block/blk.h
> > @@ -167,14 +167,15 @@ static inline int queue_congestion_off_threshold(struct request_queue *q)
> >  static inline int blk_cpu_to_group(int cpu)
> >  {
> >         int group = NR_CPUS;
> > -#ifdef CONFIG_SCHED_MC
> > -       const struct cpumask *mask = cpu_coregroup_mask(cpu);
> > -       group = cpumask_first(mask);
> > -#elif defined(CONFIG_SCHED_SMT)
> > -       group = cpumask_first(topology_thread_cpumask(cpu));
> > +#ifdef CONFIG_SCHED_POWERSAVE
> > +       if (smt_capable())
> > +               group = cpumask_first(topology_thread_cpumask(cpu));
> > +       else    
> > +               group = cpumask_first(cpu_coregroup_mask(cpu));
> >  #else
> >         return cpu;
> >  #endif
> > +       /* Possible dead code?? */
> >         if (likely(group < NR_CPUS))
> >                 return group;
> >         return cpu; 
> 
> After going, WTF is block doing! I had a closer look and this doesn't
> seem right at all. The old code would use coregroup_mask when SCHED_MC
> && SCHED_SMT, the new code does something else.
> 
> Jens, what is this thing trying to do?

I understood the requirement as get first cpu in the 'core' on
a hyper-threaded system and first cpu in the 'socket' on
a non-threaded system for best cache affinity.  Based on Jens
explanation and Peter's patch, identifying last-level shared cache
works best for this case.

--Vaidy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/