linux-kernel - Re: [resubmit] Re: [PATCH] tracing: adjust shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120127124405.GA2092@x61.redhat.com>
Date:	Fri, 27 Jan 2012 10:44:06 -0200
From:	Rafael Aquini <aquini@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	linux-mm@...ck.org, Johannes Weiner <hannes@...xchg.org>,
	Minchan Kim <minchan.kim@...il.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mel@....ul.ie>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [resubmit] Re: [PATCH] tracing: adjust shrink_slab beginning
 trace event name

While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
  <tracepoint-name>_begin
  <tarcepoint-name>_end

However, the 'beginning' tracing event for shrink_slab() did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.

Signed-off-by: Rafael Aquini <aquini@...hat.com>
Reviewed-by: Minchan Kim <minchan@...nel.org>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
---
 include/trace/events/vmscan.h |    2 +-
 mm/vmscan.c                   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
index f64560e..595a6f0 100644
--- a/include/trace/events/vmscan.h
+++ b/include/trace/events/vmscan.h
@@ -179,7 +179,7 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_re
        TP_ARGS(nr_reclaimed)
 );
 
-TRACE_EVENT(mm_shrink_slab_start,
+TRACE_EVENT(mm_shrink_slab_begin,
        TP_PROTO(struct shrinker *shr, struct shrink_control *sc,
                long nr_objects_to_shrink, unsigned long pgs_scanned,
                unsigned long lru_pgs, unsigned long cache_items,
diff --git a/mm/vmscan.c b/mm/vmscan.c
index c52b235..84f4fd2 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -325,7 +325,7 @@ unsigned long shrink_slab(struct shrink_control *shrink,
                if (total_scan > max_pass * 2)
                        total_scan = max_pass * 2;
 
-               trace_mm_shrink_slab_start(shrinker, shrink, nr,
+               trace_mm_shrink_slab_begin(shrinker, shrink, nr,
                                        nr_pages_scanned, lru_pages,
                                        max_pass, delta, total_scan);
 
-- 
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/