linux-kernel - Re: [PATCH 2/4] leds-lp5521: add 'update_config' in the lp5521_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ6gGZjOw0FxL3dbvgDQ9VsbJYmgxkferkFNVcz3pzPPg@mail.gmail.com>
Date:	Fri, 27 Jan 2012 15:05:40 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rpurdie@...ys.net" <rpurdie@...ys.net>
Subject: Re: [PATCH 2/4] leds-lp5521: add 'update_config' in the lp5521_platform_data

On Sat, Jan 21, 2012 at 7:09 PM, Kim, Milo <Milo.Kim@...com> wrote:

> The value of CONFIG register(Addr 08h) is configurable.
> For supporting this feature, update_config is added in the platform data.
> If 'update_config' is not defined, the default value is
> 'LP5521_PWRSAVE_EN | LP5521_CP_MODE_AUTO | LP5521_R_TO_BATT'.
>
> To define CONFIG register in the platform data, the bit definitions were moved
> to the header file.
>
> Documentation updated : description about 'update_config' and example.
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>

Looks useful, plus you obviously was careful not to impact on
existing users, well done.

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/