linux-kernel - Re: [PATCH 4/4] leds-lp5521: redefinition of register bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbTm1VoaOZMYysEKzOtoF3ZJvWWHNGBMqeaEF1=krPVyA@mail.gmail.com>
Date:	Fri, 27 Jan 2012 15:08:44 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rpurdie@...ys.net" <rpurdie@...ys.net>
Subject: Re: [PATCH 4/4] leds-lp5521: redefinition of register bits

On Sat, Jan 21, 2012 at 7:09 PM, Kim, Milo <Milo.Kim@...com> wrote:

> For better readability, values of LP5521_REG_ENABLE register were redefined.
> Additional definitions: LP5521_ENABLE_DEFAULT and LP5521_ENABLE_RUN_PROGRAM.
>
> Use definition rather than hard code value.
> : 0x3F -> 'LP5521_CMD_DIRECT'
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>

Looks like a good idea.

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/