linux-kernel - Re: [PATCH v2] proc: speedup /proc/stat handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120127100933.5e782a33.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Fri, 27 Jan 2012 10:09:33 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Glauber Costa <glommer@...allels.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Paul Tuner <pjt@...gle.com>
Subject: Re: [PATCH v2] proc:  speedup /proc/stat handling

On Thu, 26 Jan 2012 16:43:42 -0800
Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Thu, 26 Jan 2012 18:55:20 +0900
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:
> 
> > On Wed, 25 Jan 2012 17:04:16 -0800
> > Andrew Morton <akpm@...ux-foundation.org> wrote:
> > 
> > > On Wed, 25 Jan 2012 06:29:32 +0100
> > > Eric Dumazet <eric.dumazet@...il.com> wrote:
> > > 
> > > > Le mardi 24 janvier 2012 __ 17:27 -0800, Andrew Morton a __crit :
> > > > 
> > > > > I had a fiddle on an 8-way x86_64 machine.  I'm unable to demonstrate
> > > > > any improvement for either of
> > > > > 
> > > > > time (for i in $(seq 1000); do; cat /proc/self/stat > /dev/null; done)
> > > > > time (for i in $(seq 1000); do; cat /proc/1/stat > /dev/null; done)
> > > > > 
> > > > > oh well.
> > > > 
> > > > What size is /proc/stat ?
> > > 
> > > About 40mm, but it depends on the font size.
> > > 
> > > > wc -c /proc/stat
> > > > 
> > > > If under 4096, there is no problem with existing code.
> > > 
> > > akpm2:/home/akpm> wc -c /proc/stat 
> > > 2800 /proc/stat
> > > 
> > > > I had the problem on a 16-way machine.
> > > 
> > > OK..
> > 
> > 
> > I wrote following patch just for my fun, which makes /proc/stat twice fast.
> > But I'm not sure whether this kind of dirty && special printk is worth to do or not..
> > because I can't see /proc/stat cost at shell-scripting.
> 
> It is rather a lot of not-very-general infrastructure.
> 
> >
> > ...
> >
> > @@ -131,8 +143,8 @@ static int show_stat(struct seq_file *p, void *v)
> >  	seq_printf(p, "intr %llu", (unsigned long long)sum);
> >  
> >  	/* sum again ? it could be updated? */
> > -	for_each_irq_nr(j)
> > -		seq_printf(p, " %u", kstat_irqs(j));
> > +	j = 0;
> > +	seq_printnum_batch(p, " %u", &j, get_next_kstat_irq);
> 
> I expect most of these numbers are zero.  I wonder if we would get
> useful speedups from
> 
> 	for_each_irq_nr(j) {
> 		/* Apologetic comment goes here */
> 		if (kstat_irqs(j))
> 			seq_printf(p, " %u", kstat_irqs(j));
> 		else
> 			seq_puts(p, " 0");
> 	}

Yes. This is very good optimization and shows much optimization.
I did this at first try  but did complicated ones because it seems
not interesting. (This is my bad habit...)

I'll try again and measure time.

Thanks,
-Kame




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/