[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4D68720C2E767A4AA6A8796D42C8EB5902FDBA@BGSMSX101.gar.corp.intel.com>
Date: Fri, 27 Jan 2012 16:27:47 +0000
From: "R, Durgadoss" <durgadoss.r@...el.com>
To: Alan Cox <alan@...rguk.ukuu.org.uk>,
"mjg@...hat.com" <mjg@...hat.com>,
"platform-driver-x86@...r.kernel.org"
<platform-driver-x86@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 5/5] platform-x86: intel_mid_thermal: turn off
thermistor voltage by default
> -----Original Message-----
> From: platform-driver-x86-owner@...r.kernel.org [mailto:platform-driver-x86-
> owner@...r.kernel.org] On Behalf Of Alan Cox
> Sent: Thursday, January 26, 2012 11:10 PM
> To: mjg@...hat.com; platform-driver-x86@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH 5/5] platform-x86: intel_mid_thermal: turn off thermistor
> voltage by default
>
> From: Mika Westerberg <mika.westerberg@...ux.intel.com>
>
> Instead of complaining that the voltage is on, we can just ask the MSIC to
> turn the voltage off. This should save some power.
>
> Voltage for thermistors is turned on when ADC conversion is initiated.
Acked-by: Durgadoss R <durgadoss.r@...el.com>
Thanks,
Durga
>
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> Signed-off-by: Alan Cox <alan@...ux.intel.com>
> ---
>
> drivers/platform/x86/intel_mid_thermal.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>
> diff --git a/drivers/platform/x86/intel_mid_thermal.c
> b/drivers/platform/x86/intel_mid_thermal.c
> index aef4979..a4e56be 100644
> --- a/drivers/platform/x86/intel_mid_thermal.c
> +++ b/drivers/platform/x86/intel_mid_thermal.c
> @@ -360,8 +360,10 @@ static int mid_initialize_adc(struct device *dev)
> if (ret)
> return ret;
>
> - if (data & MSIC_ADCTHERM_MASK)
> - dev_warn(dev, "ADCTHERM already set");
> + data &= ~MSIC_ADCTHERM_MASK;
> + ret = intel_msic_reg_write(INTEL_MSIC_ADC1CNTL3, data);
> + if (ret)
> + return ret;
>
> /* Index of the first channel in which the stop bit is set */
> channel_index = find_free_channel();
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
> in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists