linux-kernel - Re: [PATCH] iommu/msm: Fix error handling in msm_iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120127164029.GQ19255@amd.com>
Date:	Fri, 27 Jan 2012 17:40:29 +0100
From:	Joerg Roedel <joerg.roedel@....com>
To:	David Brown <davidb@...eaurora.org>
CC:	<iommu@...ts.linux-foundation.org>, <linux-kernel@...r.kernel.org>,
	Stepan Moskovchenko <stepanm@...eaurora.org>
Subject: Re: [PATCH] iommu/msm: Fix error handling in msm_iommu_unmap()

On Thu, Jan 26, 2012 at 04:06:30PM -0800, David Brown wrote:
> On Thu, Jan 26, 2012 at 06:29:44PM +0100, Joerg Roedel wrote:
> > Error handling in msm_iommu_unmap() is broken. On some error
> > conditions retval is set to a non-zero value which causes
> > the function to return 'len' at the end. This hides the
> > error from the user. Zero should be returned in those error
> > cases.
> > 
> > Cc: David Brown <davidb@...eaurora.org>
> > Cc: Stepan Moskovchenko <stepanm@...eaurora.org>
> > Signed-off-by: Joerg Roedel <joerg.roedel@....com>
> > ---
> >  drivers/iommu/msm_iommu.c |    7 +------
> >  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> Acked-by: David Brown <davidb@...eaurora.org>

Thanks. I'll queue this up with iommu fixes for 3.3 and mark it for
stable as well.


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/