linux-kernel - Re: Probing unconfigured PCI bridge resouces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120127093658.27dc258b@jbarnes-desktop>
Date:	Fri, 27 Jan 2012 09:36:58 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	linux-pci@...r.kernel.org,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: Probing unconfigured PCI bridge resouces

On Tue, 24 Jan 2012 15:50:33 +1100
Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:

> On Tue, 2012-01-24 at 15:25 +1100, Benjamin Herrenschmidt wrote:
>  .../...
> 
> > Or am I missing some important fact here ?
> 
> Ok, I think I was missing pci_bridge_check_ranges(), gotta figure now
> why this didn't kick in properly for me, probably some arch code
> crackpot.
> 
> One thing I noticed is that we do clear IORESOURCE_UNSET in setup-res.c
> when setting up a device resource but we don't clear it for bridges in
> generic code ever, so it leaks all the way through from my early arch
> code. Not a big deal but annoying.

Maybe you can fix that when you unify your arch resource handling code
with the core one day. :)

There have been a lot of changes to handle re-allocation and such, and
I'm sure there's more duplication now...

-- 
Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)