linux-kernel - Re: [PATCH] pciehp: Disable/enable link during slot power off/on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F22E136.5010404@oracle.com>
Date:	Fri, 27 Jan 2012 09:39:02 -0800
From:	Yinghai Lu <yinghai.lu@...cle.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
CC:	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pciehp: Disable/enable link during slot power off/on

On 01/27/2012 09:26 AM, Jesse Barnes wrote:

> On Fri, 02 Dec 2011 15:10:08 -0800
> Yinghai Lu <yinghai.lu@...cle.com> wrote:
> 
>>
>> One system have repeater in system board to support gen2 hotplug.
>>
>> Found when EM is removed from some slots, /var/log/message will be full of
>> "card present/not present" warning.
>>
>> It turns out root complex still try to train the link to repeater because
>> repeater is not reset.
>>
>> This patch will disable link to make repeater could reset properly.
>> Also could kill AER during EM removal.
>>
>> Recently when testing hotplug on one system under development, found if boot
>> the system without EM, and later hotplug does not work with Linux.
>> But other OS is ok.
>> The root cause is that bios left link disabled when slot is empty,
>> and other OS is playing link disable bit in link ctrl during power on/off.
>>
>> So We could do the same thing to disable/enable link during power off/on.
>>
>> Signed-off-by: Yinghai Lu <yinghai.lu@...cle.com>
> 
> Ok I had to massage that commit message quite a bit, please let me know
> if it's still accurate.
> 
> The 100ms delay still needs to be clarified; if it's really necessary
> maybe we could move the delays into a delayed work handler?


Please you check updated versions that i sent later.

it was changed to three patches... i sent those patchs 1/123

git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci-hp

you can find other patches in 

git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci2

and

git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci-busn-alloc

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/