linux-kernel - Re: [RFC c/r 2/4] [RFC] syscalls, x86: Add __NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F230A40.8000203@parallels.com>
Date:	Sat, 28 Jan 2012 00:34:08 +0400
From:	Glauber Costa <glommer@...allels.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
CC:	<gorcunov@...nvz.org>, <linux-kernel@...r.kernel.org>,
	<akpm@...ux-foundation.org>, <ebiederm@...ssion.com>,
	<xemul@...nvz.org>, <xemul@...allels.com>, <avagin@...nvz.org>,
	<kosaki.motohiro@...il.com>, <mingo@...e.hu>, <hpa@...or.com>,
	<tglx@...utronix.de>, <andi@...stfloor.org>, <tj@...nel.org>,
	<matthltc@...ibm.com>, <penberg@...nel.org>,
	<eric.dumazet@...il.com>, <segoon@...nwall.com>,
	<adobriyan@...il.com>, <Valdis.Kletnieks@...edu>
Subject: Re: [RFC c/r 2/4] [RFC] syscalls, x86: Add __NR_kcmp syscall v7

>> +	case KCMP_SYSVSEM:
>> +#ifdef CONFIG_SYSVIPC
>> +		ret = kcmp_ptr((long)task1->sysvsem.undo_list,
>> +			       (long)task2->sysvsem.undo_list,
>> +			       KCMP_SYSVSEM);
>> +#else
>> +		ret = -EINVAL;
> 
> ENOTSUP is better, I think. because of, EINVAL implicitly mean _caller_ is wrong.
> but in this case, it is not bad. only the kernel doesn't have enough feature.
> 

Isn't it usually the case for ENOSYS, then ?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/