[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120128221945.GA26708@pengutronix.de>
Date: Sat, 28 Jan 2012 23:19:45 +0100
From: Wolfram Sang <w.sang@...gutronix.de>
To: Axel Lin <axel.lin@...il.com>
Cc: linux-kernel@...r.kernel.org, Paul Cercueil <paul@...pouillou.net>,
Lars-Peter Clausen <lars@...afoo.de>,
Wim Van Sebroeck <wim@...ana.be>,
linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v3] watchdog: Convert jz4740_wdt driver to watchdog core
On Thu, Jan 26, 2012 at 06:10:45PM +0800, Axel Lin wrote:
> This patch converts jz4740_wdt driver to use watchdog core APIs.
> Also use devm_* APIs to save a few error handling code.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> Acked-by: Paul Cercueil <paul@...pouillou.net>
> ---
> v3: - Remove unused define for WDT_IN_USE and WDT_OK_TO_CLOSE
> - Remove mem from struct jz4740_wdt_drvdata
>
> v2: Address all the comments by Wolfram.
> - Remove unneed header file inclusion
> - Drop 'heartbeat' usage in jz4740_wdt_set_heartbeat and jz4740_wdt_start
> - Init wdt_dev->timeout in probe using the global 'heartbeat'
> - Remove unneed pointer check for drvdata->mem
Reviewed-by: Wolfram Sang <w.sang@...gutronix.de>
Thanks!
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)
Powered by blists - more mailing lists