[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120129151421.GC4312@phenom.ffwll.local>
Date: Sun, 29 Jan 2012 16:14:21 +0100
From: Daniel Vetter <daniel@...ll.ch>
To: Wu Fengguang <fengguang.wu@...el.com>
Cc: Daniel Vetter <daniel@...ll.ch>, Keith Packard <keithp@...thp.com>,
Takashi Iwai <tiwai@...e.de>,
"intel-gfx@...ts.freedesktop..." <intel-gfx@...ts.freedesktop.org>,
Michal Marek <mmarek@...e.com>,
LKML <linux-kernel@...r.kernel.org>,
Robert Lemaire <rlemaire@...e.com>
Subject: Re: [PATCH][rebased] drm/i915: set AUD_CONFIG N_value_index for
DisplayPort
On Sun, Jan 29, 2012 at 09:23:26PM +0800, Wu Fengguang wrote:
> > > Daniel, this is now based on linux-next. I use quilt, hope it also
> > > works for you :)
> >
> > On a quick check this patch is missing the hunk to actually write the
> > aud configuration into the register. I presume that's not intentional,
> > so can you please resend?
>
> This is weird, my outbox has the below chunk. Anyway here is the
> attached patch.
>
> @@ -6107,7 +6111,9 @@ static void ironlake_write_eld(struct dr
> if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) {
> DRM_DEBUG_DRIVER("ELD: DisplayPort detected\n");
> eld[5] |= (1 << 2); /* Conn_Type, 0x1 = DisplayPort */
> - }
> + I915_WRITE(aud_config, AUD_CONFIG_N_VALUE_INDEX); /* 0x1 = DP */
> + } else
> + I915_WRITE(aud_config, 0);
>
> Thanks,
> Fengguang
Yeah, the hunk is here, too ... Looks like I've failed with wrestling the
quilt patch a bit, sorry for the noise. But I think I've got the handle on
that now. So queued for -next, thanks for the patch.
Yours, Daniel
--
Daniel Vetter
Mail: daniel@...ll.ch
Mobile: +41 (0)79 365 57 48
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists