linux-kernel - Re: Slab corruption in floppy driver module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120129193601.GD17211@htj.dyndns.org>
Date:	Sun, 29 Jan 2012 11:36:01 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	Dirk Gouders <gouders@...bocholt.fh-gelsenkirchen.de>,
	Suresh Jayaraman <sjayaraman@...e.com>,
	LKML <linux-kernel@...r.kernel.org>, Jens Axboe <axboe@...nel.dk>
Subject: Re: Slab corruption in floppy driver module

On Fri, Jan 27, 2012 at 02:54:55PM -0500, Vivek Goyal wrote:
> floppy: Fix a crash during rmmmod
> 
> floppy driver does not call add_disk() on all the drives hence we don't take
> gendisk reference on request queue for these drives. Don't call put_disk()
> with disk->queue set, otherwise we try to put the reference we never took.
> 
> Reported-by: Dirk Gouders <gouders@...bocholt.fh-gelsenkirchen.de> 
> Signed-off-by: Vivek Goyal<vgoyal@...hat.com>

Ugh... floppy init is ugly.  Thanks for fixing this.

Acked-by: Tejun Heo <tj@...nel.org>

Jens, this one and the previous one are regression fixes and need to
be routed through v3.3-fixes.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/