linux-kernel - Re: [RFC 2/2] regmap: make use of cached entries in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120130145627.GJ4882@opensource.wolfsonmicro.com>
Date:	Mon, 30 Jan 2012 14:56:28 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [RFC 2/2] regmap: make use of cached entries in debugfs

On Mon, Jan 30, 2012 at 03:08:17PM +0100, Wolfram Sang wrote:

> -		if (!regmap_readable(map, i))
> +		if (map->cache_type == REGCACHE_NONE && !regmap_readable(map, i))

This isn't quite what you said in the changelog and isn't going to play
nicely with sparse register maps - it should be

	if (regmap_cached(map, i) || regmap_readable(map, i))

or so (regmap_cached() doesn't exist at present but it seems reasonable
that it should).

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)