[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120130190008.GA5797@infradead.org>
Date: Mon, 30 Jan 2012 17:00:08 -0200
From: Arnaldo Carvalho de Melo <acme@...hat.com>
To: Stephane Eranian <eranian@...gle.com>
Cc: linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
robert.richter@....com
Subject: Re: [PATCH] perf: fix broken perf inject -b
Em Mon, Jan 16, 2012 at 07:53:28PM +0100, Stephane Eranian escreveu:
> On Fri, Jan 13, 2012 at 5:54 PM, Stephane Eranian <eranian@...gle.com> wrote:
> > On Fri, Jan 13, 2012 at 5:53 PM, Arnaldo Carvalho de Melo <acme@...hat.com> wrote:
> >> Em Fri, Jan 13, 2012 at 03:47:31PM +0100, Stephane Eranian escreveu:
> >>> perf inject -b was broken. It would not inject any build_ids
> >>> into the stream. Furthermore, it would strip samples from the
> >>> stream.
<SNIP>
> >>> @@ -173,6 +178,7 @@ static int perf_event__inject_buildid(struct perf_tool *tool,
> >>> goto repipe;
> >>> }
> >>> + machine->pid = event->ip.pid;
> I noticed that this statement conflicts with perf buildid-list (which
> I am also fixing for pipe mode).
> I don't quite understand why, though.
Have you reached any conclusion about this problem? I haven't looked at
it in detail, could you please elaborate more?
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists