linux-kernel - Re: [PATCH] perf tools: remove .. in perf includes/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120130191429.GB5797@infradead.org>
Date:	Mon, 30 Jan 2012 17:14:29 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf tools: remove .. in perf includes/

Em Fri, Jan 20, 2012 at 12:36:44PM -0800, Andi Kleen escreveu:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> The perf user space has a lot of includes with ugly .. chains. This also
> makes it impossible to include any perf files from other code.
> 
> I think the original reason for this were some wrapper include files
> for the kernel includes, and the explicit paths were needed to avoid
> endless recursion. A better way to handle this is #include_next
> 
> - Add all the relevant directories as -I in the Makefile
> - Remove (near) all the .. in include statements
> - Remove unnecessary wrappers that do nothing
> - Fix up some fallout
> 
> This makes the code more pleasant to read.
> 
> I did it all in one big patch to keep bisectability.

It builds, but breaks this:

[acme@...lia linux]$ make help | grep perf
  perf-tar-src-pkg    - Build perf-3.2.0.tar source tarball
  perf-targz-src-pkg  - Build perf-3.2.0.tar.gz source tarball
  perf-tarbz2-src-pkg - Build perf-3.2.0.tar.bz2 source tarball
  perf-tarxz-src-pkg  - Build perf-3.2.0.tar.xz source tarball
[acme@...lia linux]$ make perf-tarxz-src-pkg
  TAR
[acme@...lia linux]$ ls -la perf-3.2.0.tar.xz
-rw-rw-r--   1 acme acme    391180 Jan 30 14:48 perf-3.2.0.tar.xz
[acme@...lia linux]$ mv perf-3.2.0.tar.xz /tmp
[acme@...lia linux]$ cd /tmp
[acme@...lia tmp]$ tar xvf perf-3.2.0.tar.xz 
perf-3.2.0/
perf-3.2.0/arch/
perf-3.2.0/arch/alpha/
<SNIP>
[acme@...lia tmp]$ cd perf-3.2.0
[acme@...lia perf-3.2.0]$ l
total 36
drwxrwxr-x   6 acme acme  4096 Jan 30 14:48 ./
drwxrwxrwt.  6 root root 12288 Jan 30 14:48 ../
drwxrwxr-x  27 acme acme  4096 Jan 30 14:48 arch/
-rw-rw-r--   1 acme acme    41 Jan 30 14:48 HEAD
drwxrwxr-x   3 acme acme  4096 Jan 30 14:48 include/
drwxrwxr-x   2 acme acme  4096 Jan 30 14:48 lib/
drwxrwxr-x   3 acme acme  4096 Jan 30 14:48 tools/
[acme@...lia perf-3.2.0]$ make -C tools/perf/ install
make: Entering directory `/tmp/perf-3.2.0/tools/perf'
make[1]: *** No rule to make target `kernelversion'.  Stop.
PERF_VERSION = 
make: Leaving directory `/tmp/perf-3.2.0/tools/perf'
make: Entering directory `/tmp/perf-3.2.0/tools/perf'
make[1]: *** No rule to make target `kernelversion'.  Stop.
    GEN common-cmds.h
    * new build flags or prefix
    CC perf.o
make: *** No rule to make target `../../arch/x86/lib/memset_64.S',
needed by `builtin-annotate.o'.  Stop.
make: Leaving directory `/tmp/perf-3.2.0/tools/perf'
[acme@...lia perf-3.2.0]$

I mean jusst the:

make: *** No rule to make target `../../arch/x86/lib/memset_64.S',

part, the other one (kernelversion), if you fix, double brownie points
to ya :-)

- Arnaldo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/