linux-kernel - Re: [PATCH 1/2] um: Use generic io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120130192552.GL23916@ZenIV.linux.org.uk>
Date:	Mon, 30 Jan 2012 19:25:52 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Richard Weinberger <richard@....at>
Cc:	user-mode-linux-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] um: Use generic io.h

On Mon, Jan 30, 2012 at 06:23:33PM +0000, Al Viro wrote:
> On Wed, Jan 25, 2012 at 06:23:53PM +0100, Richard Weinberger wrote:
> > There is no need to implement our own basic io functions.
> > All we need exists already in asm-generic/io.h
> 
> Then just do
> 
> git rm arch/um/include/asm/io.h
> echo 'generic-y += io.h' >>arch/um/include/asm/Kbuild
> git add arch/um/include/asm/Kbuild
> 
> and be done with that.  We are already using generic-y for a bunch of
> headers there...

While we are at it, param.h and pci.h appear to be candidates for the
same treatment, along with delay.h and auxvec.h.  mutex.h as well...
BTW, we probably can kill arch/um/include/asm/asm-offsets.h - everything
in there is using generated/asm-offsets.h directly.

FWIW, I'd probably kill current.h as well - replace get_current() in
arch/um/kernel/process.c with get_current_pid() (i.e. task_pid_nr(current)),
kill HOST_TASK_PID and switch arch/x86/um/bugs_32.c to use of get_current_pid()
and we can switch to asm-generic/current.h just fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/