linux-kernel - Re: [PATCH 4/5] TTY: pty, remove superfluous ptm test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120130203744.16483d19@pyramind.ukuu.org.uk>
Date:	Mon, 30 Jan 2012 20:37:44 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org, alan@...ux.intel.com,
	jirislaby@...il.com
Subject: Re: [PATCH 4/5] TTY: pty, remove superfluous ptm test

On Mon, 30 Jan 2012 21:14:31 +0100
Jiri Slaby <jslaby@...e.cz> wrote:

> The code looks like:
> if (tty->driver->subtype == PTY_TYPE_MASTER) {
>   ...
>   if (tty->driver == ptm_driver)
> 
> But the second if is superfluous because only the ptm_driver is of
> PTY_TYPE_MASTER subtype.
> 
> Also we can remove the #if now because devpts_pty_kill is defined as
> an empty function for non-CONFIG_UNIX98_PTYS configs.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

Acked-by: Alan Cox <alan@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/