linux-kernel - Re: [PATCH] slub: prefetch next freelist pointer in slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1201301549240.3895@router.home>
Date:	Mon, 30 Jan 2012 15:53:51 -0600 (CST)
From:	Christoph Lameter <cl@...ux.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
cc:	Pekka Enberg <penberg@...nel.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	David Rientjes <rientjes@...gle.com>,
	"Alex,Shi" <alex.shi@...el.com>, Shaohua Li <shaohua.li@...el.com>,
	Matt Mackall <mpm@...enic.com>,
	Linux-Next <linux-next@...r.kernel.org>
Subject: Re: [PATCH] slub: prefetch next freelist pointer in slab_alloc()

On Mon, 30 Jan 2012, Geert Uytterhoeven wrote:

> On Tue, Jan 24, 2012 at 20:54, Pekka Enberg <penberg@...nel.org> wrote:
> > On Fri, 16 Dec 2011, Eric Dumazet wrote:
> >>> Recycling a page is a problem, since freelist link chain is hot on
> >>> cpu(s) which freed objects, and possibly very cold on cpu currently
> >>> owning slab.
> >
> > On Fri, 16 Dec 2011, Christoph Lameter wrote:
> >> Good idea. How do the tcp benchmarks look after this?
> >>
> >> Looks sane.
> >>
> >> Acked-by: Christoph Lameter <cl@...ux.com>
> >
> > Applied, thanks!
>
> m68k/allmodconfig at http://kisskb.ellerman.id.au/kisskb/buildresult/5527349/
>
> mm/slub.c:274: error: implicit declaration of function 'prefetch'
>
> Sorry, didn't notice it earlier due to other build breakage in -next.

Does this fix it?


Subject: slub: include include for prefetch

Otherwise m68k breaks.

Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Signed-off-by: Christoph Lameter <cl@...ux.com>


---
 mm/slub.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2012-01-13 10:04:06.000000000 -0600
+++ linux-2.6/mm/slub.c	2012-01-30 15:51:55.000000000 -0600
@@ -29,6 +29,7 @@
 #include <linux/math64.h>
 #include <linux/fault-inject.h>
 #include <linux/stacktrace.h>
+#include <linux/prefetch.h>

 #include <trace/events/kmem.h>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/